chore(scaffold): Explicitly set minimum required Jahia version #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptistegrimaud
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit required-version field to package.json templates in the JavaScript module scaffolding tool, setting the minimum Jahia version to "8.2.1.0" instead of relying on the default value.
Changes:
- Added
required-versionfield with value "8.2.1.0" to all three package.json templates (template-set, module, and hello-world)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript-create-module/templates/template-set/package.json | Added explicit minimum Jahia version requirement |
| javascript-create-module/templates/module/package.json | Added explicit minimum Jahia version requirement |
| javascript-create-module/templates/hello-world/package.json | Added explicit minimum Jahia version requirement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GauBen
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Jahia/user-password-authentication#140.
Description
When generating the skeleton of a JavaScript Module project with https://www.npmjs.com/package/@jahia/create-module, define the mininum Jahia version required (
required-versionfield) in thepackage.json.This way, the version is explicit instead of relying on the default value (see https://github.com/Jahia/javascript-modules/blob/main/javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/jshandler/JavascriptProtocolConnection.java#L242).
Tip
Documentation to guide the reviews: How to do a code review